From 12abae6da924cb33858fbc9948fdf7a181e2038c Mon Sep 17 00:00:00 2001
From: Fibinger Ádám <adam.fibinger@wup.hu>
Date: Tue, 12 Mar 2019 19:31:27 +0100
Subject: [PATCH] Decoupling final version
---
src/main/java/hu/unr/fiber/cardapi/CardController.java | 107 ++++++++++++++++++++---------------------------------
1 files changed, 40 insertions(+), 67 deletions(-)
diff --git a/src/main/java/hu/unr/fiber/cardapi/CardController.java b/src/main/java/hu/unr/fiber/cardapi/CardController.java
index 76aff0f..141cd21 100644
--- a/src/main/java/hu/unr/fiber/cardapi/CardController.java
+++ b/src/main/java/hu/unr/fiber/cardapi/CardController.java
@@ -2,25 +2,28 @@
import java.net.URI;
import java.util.List;
-import java.util.Optional;
+import hu.unr.fiber.cardapi.interfaces.CardInvalidUpdateException;
+import hu.unr.fiber.cardapi.interfaces.CardNotFoundException;
+import hu.unr.fiber.cardapi.interfaces.CardInterface;
+import hu.unr.fiber.cardapi.hibernate.CardInteractor;
+import hu.unr.fiber.cardapi.rest.RestCard;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.*;
+import org.springframework.web.server.ResponseStatusException;
import org.springframework.web.util.UriComponentsBuilder;
@RestController
public class CardController {
Logger logger = LoggerFactory.getLogger(CardController.class);
+ private CardInteractor cardService;
- CardController(CardRepository cR)
- {
- this.cardRepository = cR;
+ CardController(CardInteractor cS) {
+ this.cardService = cS;
}
-
- CardRepository cardRepository;
@GetMapping("/")
public String index() {
@@ -29,91 +32,62 @@
}
@GetMapping("/cards")
- public List<Card> cards() {
+ public ResponseEntity<List<CardInterface>> cards() {
logger.info("GET /cards called, responded with items.");
- return cardRepository.findAll();
+ List<CardInterface> cardList = cardService.getCardList();
+ return ResponseEntity.ok().body(cardList);
}
@GetMapping(value = "/card/{id}")
- public ResponseEntity<Card> getCard(@PathVariable("id") long id) {
+ public ResponseEntity<CardInterface> getCard(@PathVariable("id") long id) {
logger.info("GET /card/" + id + " called.");
- if (!this.cardRepository.existsById(id)) {
- return ResponseEntity.notFound().build();
+ try {
+ CardInterface card = this.cardService.getCardById(id);
+ return ResponseEntity.ok().body(card);
+ } catch (CardNotFoundException e) {
+ throw new ResponseStatusException(HttpStatus.NOT_FOUND, "No such card with id: #" + id);
}
-
- Card card = this.cardRepository.getOne(id);
-
- return ResponseEntity.ok().body(card);
}
@DeleteMapping(value = "/card/{id}")
public ResponseEntity<String> deleteCard(@PathVariable("id") long id) {
logger.info("DELETE /card/" + id + " called");
- return Optional
- .ofNullable(this.cardRepository.getOne(id))
- .map(
- card -> {
- this.cardRepository.delete(card);
- this.cardRepository.flush();
- return ResponseEntity.ok().body("OK");
- }
- )
- .orElseGet(() -> ResponseEntity.status(HttpStatus.NOT_FOUND).body("No card available with id: "+ id));
+ try {
+ this.cardService.delete(id);
+ } catch (CardNotFoundException e) {
+ throw new ResponseStatusException(HttpStatus.NOT_FOUND, "No such card with id: #" + id, e);
+ }
+
+ return ResponseEntity.ok().body("OK");
}
@PostMapping(value = "/card/{id}")
- public ResponseEntity<String> updateCard(@PathVariable("id") long id, @RequestBody Card updatedCard, UriComponentsBuilder ucBuilder) {
+ public ResponseEntity<String> updateCard(@PathVariable("id") long id, @RequestBody RestCard updatedCardEntity, UriComponentsBuilder ucBuilder) {
- logger.info("POST /card/"+ id + " called, card update.");
-
- if (updatedCard.validId() && (updatedCard.getId() != id))
- {
- return ResponseEntity
- .badRequest()
- .body("Id field cannot be modified.");
+ logger.info("POST /card/" + id + " called, card update.");
+ try {
+ this.cardService.update(id, updatedCardEntity);
+ } catch (CardInvalidUpdateException e) {
+ throw new ResponseStatusException(HttpStatus.BAD_REQUEST, e.getMessage());
+ } catch (CardNotFoundException e) {
+ throw new ResponseStatusException(HttpStatus.NOT_FOUND, "No such card with id: #" + id, e);
}
-
- Card originalCard = this.cardRepository.getOne(id);
-
- if (originalCard.equals(updatedCard)) {
- return ResponseEntity.accepted().body("Update has no changes.");
- }
-
- //card number updated, we have to check if its already exists
- if (!originalCard.getNumber().equals(updatedCard.getNumber()) && this.getCardByNumber(updatedCard.getNumber()) != null) {
- logger.error("Unable to update card with id {}. A different Card with number {} already exist", originalCard.getId(), updatedCard.getNumber());
- return ResponseEntity.status(HttpStatus.CONFLICT).body("Card with number " + updatedCard.getNumber() + " already exists.");
- }
-
- originalCard.update(updatedCard);
- this.cardRepository.flush();
return ResponseEntity.accepted().body("OK");
}
- private Card getCardByNumber(String number) {
-
- Long id = cardRepository.findIdByNumber(number);
-
- if (id == null) {
- return null;
- }
-
- return cardRepository.getOne(id);
- }
-
@PostMapping(value = "/card")
- public ResponseEntity<String> createCard(@RequestBody Card card, UriComponentsBuilder ucBuilder) {
- logger.info("Creating Card : {}", card.getNumber());
+ public ResponseEntity<String> createCard(@RequestBody RestCard card, UriComponentsBuilder ucBuilder) {
+ logger.info("Creating RestCard : {}", card.getNumber());
- if (this.getCardByNumber(card.getNumber()) != null) {
- logger.error("Unable to create. A Card with number {} already exist", card.getNumber());
- return ResponseEntity.status(HttpStatus.CONFLICT).body("Card with number "+ card.getNumber() + " already exists.");
+ try {
+ CardInterface c = this.cardService.create(card);
+ card.setId(c.getId());
+ } catch (CardInvalidUpdateException e) {
+ throw new ResponseStatusException(HttpStatus.CONFLICT, e.getMessage());
}
-
- this.cardRepository.saveAndFlush(card);
URI newCardURI = ucBuilder.path("/card/{id}").buildAndExpand(card.getId()).toUri();
@@ -121,5 +95,4 @@
.created(newCardURI)
.body(newCardURI.toString());
}
-
}
\ No newline at end of file
--
Gitblit v1.8.0